Re: To Andres Freund 2016-04-14 <20160414092919.GA11804@msg.df7cb.de>
> > That fixed the contrib/test_decoding checks, thanks.
> > Will do another full build over night to double check.
>
> ... the patch worked indeed, thanks!
Duh, the patch does work on sparc, but it breaks amd64:
*** /home/cbe/projects/postgresql/debian/9.4/build/../contrib/test_decoding/expected/ddl.out 2016-03-28
22:09:55.000000000+0200
--- /home/cbe/projects/postgresql/debian/9.4/build/contrib/test_decoding/./regression_output/results/ddl.out
2016-04-1413:12:45.310632488 +0200
***************
*** 189,201 ****
FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1')
GROUP BY substring(data, 1, 24)
ORDER BY 1,2;
! count | min | max
!
-------+-------------------------------------------------+------------------------------------------------------------------------
! 1 | BEGIN | BEGIN
! 1 | COMMIT | COMMIT
! 20467 | table public.tr_etoomuch: DELETE: id[integer]:1 | table public.tr_etoomuch: UPDATE: id[integer]:9999
data[integer]:-9999
! (3 rows)
!
-- check updates of primary keys work correctly
BEGIN;
CREATE TABLE spoolme AS SELECT g.i FROM generate_series(1, 5000) g(i);
--- 189,195 ----
FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1')
GROUP BY substring(data, 1, 24)
ORDER BY 1,2;
! ERROR: invalid memory alloc request size 94596654694480
-- check updates of primary keys work correctly
BEGIN;
CREATE TABLE spoolme AS SELECT g.i FROM generate_series(1, 5000) g(i);
Christoph