Wrong definition of pgwin32_bind.

Поиск
Список
Период
Сортировка
От Kyotaro HORIGUCHI
Тема Wrong definition of pgwin32_bind.
Дата
Msg-id 20160414.171535.27292694.horiguchi.kyotaro@lab.ntt.co.jp
обсуждение исходный текст
Ответы Re: Wrong definition of pgwin32_bind.  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
Hello.

VC complains that pgwin32_bind() had a parameter differs in
levels of indirection from definition. pgwin32_bind() in
src/backend/port/win32/socket.c is defined as the following.

> int pgwin32_bind(SOCKET s, struct sockaddr * addr, int *addrlen);

The third parameter should be int, not int*. It might have been
confused with pgwin32_accept.

The attached patch fixes this.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/port/win32/socket.c b/src/backend/port/win32/socket.c
index ea4fb55..56a13e5 100644
--- a/src/backend/port/win32/socket.c
+++ b/src/backend/port/win32/socket.c
@@ -265,7 +265,7 @@ pgwin32_socket(int af, int type, int protocol)}int
-pgwin32_bind(SOCKET s, struct sockaddr * addr, int *addrlen)
+pgwin32_bind(SOCKET s, struct sockaddr * addr, int addrlen){    int            res;
diff --git a/src/include/port/win32.h b/src/include/port/win32.h
index 9810a83..708d47a 100644
--- a/src/include/port/win32.h
+++ b/src/include/port/win32.h
@@ -373,7 +373,7 @@ void        pg_queue_signal(int signum);#define send(s, buf, len, flags) pgwin32_send(s, buf, len,
flags)SOCKET       pgwin32_socket(int af, int type, int protocol);
 
-int            pgwin32_bind(SOCKET s, struct sockaddr * addr, int *addrlen);
+int            pgwin32_bind(SOCKET s, struct sockaddr * addr, int addrlen);int            pgwin32_listen(SOCKET s, int
backlog);SOCKET       pgwin32_accept(SOCKET s, struct sockaddr * addr, int *addrlen);int
pgwin32_connect(SOCKETs, const struct sockaddr * name, int namelen); 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ashutosh Sharma
Дата:
Сообщение: pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.