Re: pgsql: Checkpoint sorting and balancing.

On 2016-03-10 20:47:10 -0500, Peter Eisentraut wrote:
> On 3/10/16 8:29 PM, Andres Freund wrote:
> > Checkpoint sorting and balancing.
>
> This patch appears to have introduced a change that makes the build
> with dtrace fail:
>
> In file included from ../../../../src/include/pg_trace.h:15:0,
>                  from bufmgr.c:42:
> bufmgr.c: In function 'BufferSync':
> bufmgr.c:1939:59: error: 'num_to_write' undeclared (first use in this function)
>   TRACE_POSTGRESQL_BUFFER_SYNC_DONE(NBuffers, num_written, num_to_write);
>                                                            ^
> ../../../../src/include/utils/probes.h:93:83: note: in definition of macro 'TRACE_POSTGRESQL_BUFFER_SYNC_DONE'
>   __dtrace_probe$postgresql$buffer__sync__done$v1$696e74$696e74$696e74(arg0, arg1, arg2); \
>                                                                                    ^~~~
> bufmgr.c:1939:59: note: each undeclared identifier is reported only once for each function it appears in
>   TRACE_POSTGRESQL_BUFFER_SYNC_DONE(NBuffers, num_written, num_to_write);
>                                                            ^
> ../../../../src/include/utils/probes.h:93:83: note: in definition of macro 'TRACE_POSTGRESQL_BUFFER_SYNC_DONE'
>   __dtrace_probe$postgresql$buffer__sync__done$v1$696e74$696e74$696e74(arg0, arg1, arg2); \
>                                                                                    ^~~~

Hrmpf.  I tried to fix the issue; could you quickly verify?

These probes are a bit annoying; and I seriously doubt anybody actually
uses them. But obviously we should keep them working as long as we have
them.

Thanks!

Andres