Re: GinPageIs* don't actually return a boolean

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: GinPageIs* don't actually return a boolean
Дата
Msg-id 20160211183929.g7hyjncswhlij6q6@alap3.anarazel.de
обсуждение исходный текст
Ответ на Re: GinPageIs* don't actually return a boolean  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: GinPageIs* don't actually return a boolean  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 2016-02-11 13:37:17 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > And anyway, these macros are a potential issue even without stdbool.h
> > style booleans.
> 
> Absolutely; they don't work safely for testing bits that aren't in the
> rightmost byte of a flag word, for instance.  I'm on board with making
> these fixes, I'm just unconvinced that stdbool is a good reason for it.

Oh, ok. Interactions with stdbool was what made me looking into this,
that's primarily why I mentioned it.   What's your thinking about
back-patching, independent of that then?



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: GinPageIs* don't actually return a boolean
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Performance degradation in commit ac1d794