Masahiko Sawada wrote:
> Attached updated version patch.
> Please review it.
In pg_upgrade, the "page convert" functionality is there to abstract
rewrites of pages being copied; your patch is circumventing it and
AFAICS it makes the interface more complicated for no good reason. I
think the real way to do that is to write your rewriteVisibilityMap as a
pageConverter routine. That should reduce some duplication there.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services