Re: Making tab-complete.c easier to maintain

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Making tab-complete.c easier to maintain
Дата
Msg-id 20151116151606.GW614468@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Making tab-complete.c easier to maintain  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Ответы Re: Making tab-complete.c easier to maintain
Список pgsql-hackers
Kyotaro HORIGUCHI wrote:

> Auto-generating from grammer should be the ultimate solution but
> I don't think it will be available. But still I found that the
> word-splitting-then-match-word-by-word-for-each-matching is
> terriblly unmaintainable and poorly capable. So, how about
> regular expressions?

I don't think this is an improvement.  It seems to me that a lot more
work is required to maintain these regular expressions, which while
straightforward are not entirely trivial (harder to read).

If we could come up with a reasonable format that is pre-processed to a
regexp, that might be better.  I think Thomas' proposed patch is closer
to that than Horiguchi-san's.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kouhei Kaigai
Дата:
Сообщение: Re: [DESIGN] ParallelAppend
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: Making tab-complete.c easier to maintain