Re: bootstrap pg_shseclabel in relcache initialization

On 2015-11-09 23:38:57 -0500, Adam Brightwell wrote:
> >> @@ -3365,6 +3370,8 @@ RelationCacheInitializePhase3(void)
> >>                                                       AuthIdRelationId);
> >>               load_critical_index(AuthMemMemRoleIndexId,
> >>                                                       AuthMemRelationId);
> >> +             load_critical_index(SharedSecLabelObjectIndexId,
> >> +                                                     SharedSecLabelRelationId);
> >>
> >>  #define NUM_CRITICAL_SHARED_INDEXES 5        /* fix if you change list above */
> >>
> >
> > Need to bump this #define?  If you didn't get the error that this is
> > supposed to throw, perhaps there's a bug somewhere worth investigating.
> 
> Hmm... I thought that I had, are you not seeing the following change?
> 
> -#define NUM_CRITICAL_SHARED_RELS    3    /* fix if you change list above */
> +#define NUM_CRITICAL_SHARED_RELS    4    /* fix if you change list above */

NUM_CRITICAL_SHARED_RELS != NUM_CRITICAL_SHARED_INDEXES