Re: nodes/*funcs.c inconsistencies

Peter Geoghegan wrote:
> On Sun, Aug 2, 2015 at 3:07 PM, Peter Geoghegan <pg@heroku.com> wrote:
> > I'm surprised that this stuff was only ever used for logical decoding
> > infrastructure so far.
> 
> On second thought, having tried it, one reason is that that breaks
> things that are considered legitimate for historical reasons. For
> example, AttrNumber is often used with READ_INT_FIELD(), which is an
> int16. Whether or not it's worth fixing that by introducing a
> READ_ATTRNUM_FIELD() (and so on) is not obvious to me.

If it allows us to introduce additional checking for new code, I'm all
for it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services