On Sun, May 31, 2015 at 10:49:46PM -0700, Michael Paquier wrote:
> I have just noticed that the commands contribcheck and modulescheck
> will fail as follows if the temporary installation is not done in
> $ROOT_DIR/tmp_install first:
> C:\Users\ioltas\git\postgres\src\tools\msvc>vcregress contribcheck
> ============================================================
> Checking btree_gin
> The system cannot find the path specified.
>
> All the other commands call InstallTemp() so as to have them work
> independently. For consistency I think that we should do the same for
> them. Attached is a patch to fix that.
> --- a/src/tools/msvc/vcregress.pl
> +++ b/src/tools/msvc/vcregress.pl
> @@ -290,6 +290,7 @@ sub subdircheck
>
> sub contribcheck
> {
> + InstallTemp();
This worked around defects in commit dcae5fa: "check", "ecpgcheck" and
"upgradecheck" are the only test targets properly requiring an installation.
The others are installcheck-style targets that need just a couple of binaries
from the build tree; they should be using --bindir=<relpath>/$Config/psql like
installcheck itself.