Re: Lack of Sanity Checking in file 'misc.c' for PostgreSQL 9.4.x

Поиск
Список
Период
Сортировка
От Michael Meskes
Тема Re: Lack of Sanity Checking in file 'misc.c' for PostgreSQL 9.4.x
Дата
Msg-id 20150612130635.GC27586@feivel.credativ.lan
обсуждение исходный текст
Ответ на Re: Lack of Sanity Checking in file 'misc.c' for PostgreSQL 9.4.x  (Michael Paquier <michael.paquier@gmail.com>)
Ответы Re: Lack of Sanity Checking in file 'misc.c' for PostgreSQL 9.4.x  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-bugs
Дерево обсуждения 
On Fri, Jun 12, 2015 at 03:53:43PM +0900, Michael Paquier wrote:
> (Adding Michael Meskes in CC:)

Thanks.

> Nice catch. Regarding your patch, it seems to me that this is not
> enough. I think that we should return NULL with ECPGget_sqlca in case
> of an OOM instead of logging a message with ecpg_log and let each code
> path decide what to do when sqlca is NULL. Some code paths can
> directly use ecpg_raise with ECPG_OUT_OF_MEMORY. Other code paths,
> like the ones in error.c will need to show up with appropriate error
> messages.

Agreed on all accounts.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Michael Meskes
Дата:
Сообщение: Re: Lack of Sanity Checking in file 'misc.c' for PostgreSQL 9.4.x
Следующее
От: polpot78@gmail.com
Дата:
Сообщение: BUG #13437: Seq Scan increases heap_blks_read instead of heap_blks_hit when no disk is read