Missing XLOG_DEBUG check in AdvanceXLInsertBuffer()?
| От | Andres Freund |
|---|---|
| Тема | Missing XLOG_DEBUG check in AdvanceXLInsertBuffer()? |
| Дата | |
| Msg-id | 20150610110253.GF3832@alap3.anarazel.de обсуждение |
| Ответы |
Re: Missing XLOG_DEBUG check in AdvanceXLInsertBuffer()?
Re: Missing XLOG_DEBUG check in AdvanceXLInsertBuffer()? |
| Список | pgsql-hackers |
Hi,
When compiling with WAL_DEBUG defined, but wal_debug set to off, there's
a lot of DEBUG1 spew like
DEBUG: initialized 1 pages, upto 40/3977E000
DEBUG: initialized 9 pages, upto 40/39790000
DEBUG: initialized 1 pages, upto 40/39792000
DEBUG: initialized 1 pages, upto 40/39794000
DEBUG: initialized 1 pages, upto 40/39796000
DEBUG: initialized 1 pages, upto 40/39798000
I find that quite annoying. That specific elog() has been there since
9a20a9b21 in 9.4.
Does somebody mind me backpatching the missing XLOG_DEBUG &&?
#ifdef WAL_DEBUGif (XLOG_DEBUG && npages > 0){ elog(DEBUG1, "initialized %d pages, upto %X/%X", npages,
(uint32)(NewPageEndPtr >> 32), (uint32) NewPageEndPtr);}
#endif
Greetings,
Andres Freund
В списке pgsql-hackers по дате отправления: