All,
* Robert Haas (robertmhaas@gmail.com) wrote (on the role attributes
* thread):
> I think this patch is too big and does too many things. It should be
> broken up into small patches which can be discussed and validated
> independently. The fact that your commit message is incredibly long
> is a sign that there's too much going on here, and that message
> doesn't even cover all of it.
As I mentioned on another thread, you're certainly right about that, and
here's the first broken-out patch, which just changes
pg_stat_get_activity to build and return a tuplestore in a single
function call instead of using the old-style multiple-invokation call
method. Given the simplicity and the lack of any user-visible change,
and that it's an independently useful change regardless of what happens
with the other changes, I'm planning to move forward with this pretty
quickly, barring concerns, of course.
This is heavily based on the pg_stat_get_wal_senders() implementation,
hat-tip to Itagaki Takahiro for that.
Thanks!
Stephen