Re: BUG #12755: pg_upgrage creates potentially dangerous delete_old_cluster.bat

On Tue, Feb 10, 2015 at 10:44:41AM +0000, toni.helenius@syncrontech.com wrote:
> The following bug has been logged on the website:
>
> Bug reference:      12755
> Logged by:          Toni Helenius
> Email address:      toni.helenius@syncrontech.com
> PostgreSQL version: 9.4.1
> Operating system:   Windows 7
> Description:
>
> pg_upgrage creates potentially dangerous delete_old_cluster.bat. RMDIR
> without quotes.
>
> RMDIR /s/q C:\Program Files\PostgreSQL\9.3\data
>
> Executes as:
> RMDIR /s/q C:\Program
>
> Needs quotes!!

Wow, very good point.  Not sure why this problem was not reported
before.  Patch attached.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +