Re: POLA violation with \c service=

On 2015-01-10 09:16:07 -0500, Andrew Dunstan wrote:
>    +static const char uri_designator[] = "postgresql://";
>    +static const char short_uri_designator[] = "postgres://";
> 
> These declarations in common.h would cause a separate instance of these
> pieces of storage to occur in every object file where the .h file had been
> #included. In general, you should not expect to see any static declarations
> in .h files.

Save static inline functions, that is.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services