Re: Defining dedicated macro to grab a relation's persistence

Hi,

On 2014-11-07 22:08:33 +0900, Michael Paquier wrote:
> After looking at a patch of this commit fest using
> rd_rel->relpersistence, I got a look at how many times this expression
> was being used directly in the backend code and wondered if it would
> not be useful to add a dedicated macro in rel.h to get the persistence
> of a relation like in the patch attached. (Note: it is actually used
> 39 times).

I personally find the direct access actually more readable, so I'm not a
fan of further extending the scheme. Consistency with some other common
accessors is an argument though.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services