GCC memory barriers are missing "cc" clobbers

Hi,

barrier.h defines memory barriers for x86 as:
32bit:
#define pg_memory_barrier()           \       __asm__ __volatile__ ("lock; addl $0,0(%%esp)" : : : "memory")
64bit:
#define pg_memory_barrier()        \__asm__ __volatile__ ("lock; addl $0,0(%%rsp)" : : : "memory")

But addl sets condition flags. So this really also needs a "cc" clobber?
Or am I missing something?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services