Re: strncpy is not a safe version of strcpy

On Thu, Aug 14, 2014 at 02:50:02AM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Wed, Aug 13, 2014 at 10:21:50AM -0400, Tom Lane wrote:
> >> I believe that we deal with this by the expedient of checking the lengths
> >> of tablespace paths in advance, when the tablespace is created.
> 
> > The files under scrutiny here are not located in a tablespace.  Even if they
> > were, isn't the length of $PGDATA/pg_tblspc the important factor?
> 
> The length of $PGDATA is of no relevance whatsoever; we chdir into that
> directory at startup, and subsequently all paths are implicitly relative
> to there.  If there is any backend code that's prepending $PGDATA to
> something else, it's wrong to start with.

Ah; quite right.

-- 
Noah Misch
EnterpriseDB                                 http://www.enterprisedb.com