Re: [TODO] Process pg_hba.conf keywords as case-insensitive

Re: Tom Lane 2014-07-16 <30956.1405532518@sss.pgh.pa.us>
> Christoph Berg <cb@df7cb.de> writes:
> > Re: Viswanatham kirankumar 2014-07-16 <EC867DEF52699D4189B584A14BAA7C2165440538@blreml504-mbx.china.huawei.com>
> >> Attached patch is implementing following TODO item
> >> Process pg_hba.conf keywords as case-insensitive
> 
> > Hmm. I see a case for accepting "ALL" (as in hosts.allow(5)), so +1 on
> > that, but I don't think the other keywords like "host" and "peer"
> > should be valid in upper case.
> 
> I think the argument was that SQL users are accustomed to thinking
> that keywords are case-insensitive.  It makes sense to me that we
> should adopt that same convention in pg_hba.conf.

One place that's been bugging me where case-insensitivity would really
make sense is this:

# set work_mem = '1mb';
ERROR:  22023: invalid value for parameter "work_mem": "1mb"
HINT:  Valid units for this parameter are "kB", "MB", and "GB".

Christoph
-- 
cb@df7cb.de | http://www.df7cb.de/