Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED

Hi,

I quickly looked at this patch and I think there's major missing pieces
around buffer management and wal logging.

a) Currently buffers that are in memory marked as  permanent/non-permanent aren't forced out to disk/pruned from cache,
not even when they're dirty.
 
b) When converting from a unlogged to a logged table the relation needs  to be fsynced.
c) Currently a unlogged table changed into a logged one will be  corrupted on a standby because its contents won't ever
beWAL logged.
 

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services