Re: BUG #10533: 9.4 beta1 assertion failure in autovacuum process

On 2014-06-09 10:21:54 -0400, Tom Lane wrote:
> Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> > On 06/09/2014 03:46 PM, Andres Freund wrote:
> >> Before I start working on a patch along those lines, do you see any
> >> problems with making the critical section smaller?
>
> > One subtle difference is that the PD_ALL_VISIBLE flag will not be
> > included in the full-page-image that log_heap_page() might take. But
> > that seems OK. visibilitymap_set() writes a WAL record that sets it at
> > replay.
>
> Huh?  The visibility map call is after the page image would be taken in
> any case.

But the heap_page_is_all_visible() and PageSetAllVisible() currently
aren't. And both would have to be moved to fix the issue...

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services