Re: includedir_internal headers are not self-contained

On 2014-04-28 14:44:16 -0400, Robert Haas wrote:
> > BTW, for the same reasons I'm less than impressed with the uses of
> > relpath in error messages in, eg, reorderbuffer.c:
> >
> >                     relation = RelationIdGetRelation(reloid);
> >
> >                     if (relation == NULL)
> >                         elog(ERROR, "could open relation descriptor %s",
> >                              relpathperm(change->data.tp.relnode, MAIN_FORKNUM));
> >
> > Printing anything other than the relation OID here is irrelevant,
> > misleading, and inconsistent with our practice everywhere else.
> > Let's not even mention the missing "not" in the message text.
> 
> Uggh.

I'll send a fix once I am home (~3h).

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services