On 2014-03-27 13:52:19 -0400, Noah Misch wrote:
> On Thu, Mar 27, 2014 at 12:56:02PM -0300, Alvaro Herrera wrote:
> > Also, there's the vcregress.pl business. The way it essentially
> > duplicates pg_upgrade/test.sh is rather messy; and now that
> > test_decoding also needs similar treatment, it's not looking so good.
> > Should we consider redoing that stuff in a way that allows both MSVC and
> > make-based systems to run those tests?
>
> +1
I'd like that as well, but I don't really see how.
> Incidentally, I've seen the following row-order difference for test_decoding.
> (I assumed the buildfarm would notice that quickly enough, but this thread has
> corrected that assumption.) Barring objections, I'll make it "ORDER BY 1,2".
>
> --- /home/nmisch/src/pg/postgresql/contrib/test_decoding/expected/ddl.out 2014-03-23 07:32:25.718189175 +0000
> +++ /home/nmisch/src/pg/postgresql/contrib/test_decoding/results/ddl.out 2014-03-27 17:40:33.079815557 +0000
> @@ -199,8 +199,8 @@
> ORDER BY 1;
> count | min | max
>
-------+-------------------------------------------------+------------------------------------------------------------------------
> - 1 | COMMIT | COMMIT
> 1 | BEGIN | BEGIN
> + 1 | COMMIT | COMMIT
> 20467 | table public.tr_etoomuch: DELETE: id[integer]:1 | table public.tr_etoomuch: UPDATE: id[integer]:9999
data[integer]:-9999
> (3 rows)
That sounds like a good plan. Thanks!
Greetings,
Andres Freund
-- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services