Re: Useless "Replica Identity: NOTHING" noise from psql \d

Re: Bruce Momjian 2014-03-26 <20140326161056.GA468@momjian.us>
> The attached patch matches your suggestion.  It is basically back to
> what the code originally had, except it skips system tables, and shows
> "???" for invalid values.

Fwiw, "make check-world" is currently broken:

******** build/contrib/test_decoding/regression.diffs ********
*** /tmp/buildd/postgresql-9.4-9.4~20140327.0501/build/../contrib/test_decoding/expected/ddl.out    Thu Mar 27 02:43:36
2014
--- /tmp/buildd/postgresql-9.4-9.4~20140327.0501/build/contrib/test_decoding/results/ddl.out    Thu Mar 27 05:14:02
2014
***************
*** 345,350 ****
--- 345,351 ----  options  | text[]  |                                                                   | extended |
          |  Indexes:     "replication_metadata_pkey" PRIMARY KEY, btree (id)
 
+ Replica Identity: DEFAULT Has OIDs: no Options: user_catalog_table=true 
***************
*** 360,365 ****
--- 361,367 ----  options  | text[]  |                                                                   | extended |
          |  Indexes:     "replication_metadata_pkey" PRIMARY KEY, btree (id)
 
+ Replica Identity: DEFAULT Has OIDs: no  INSERT INTO replication_metadata(relation, options)
***************
*** 374,379 ****
--- 376,382 ----  options  | text[]  |                                                                   | extended |
          |  Indexes:     "replication_metadata_pkey" PRIMARY KEY, btree (id)
 
+ Replica Identity: DEFAULT Has OIDs: no Options: user_catalog_table=true 
***************
*** 394,399 ****
--- 397,403 ----  rewritemeornot | integer |                                                                   | plain
 |              |  Indexes:     "replication_metadata_pkey" PRIMARY KEY, btree (id)
 
+ Replica Identity: DEFAULT Has OIDs: no Options: user_catalog_table=false

Christoph
-- 
cb@df7cb.de | http://www.df7cb.de/