Hi Robert, Everyone!
On 2014-03-03 16:48:15 -0500, Robert Haas wrote:
> OK, I've committed the 0001 patch, which is the core of this feature,
> with a bit of minor additional hacking.
Many, many, thanks!
> I'm sure there are some problems here yet and some things that people
> will want fixed, as is inevitable for any patch of this size. But I
> don't have any confidence that further postponing commit is going to
> be the best way to find those issues, so in it goes.
Unsurprisingly I do agree with this. It's a big feature, and there's
imperfection. But I think it's a good start.
A very first such imperfection is that the buildfarm doesn't actually
excercise make check in contribs, just make installcheck... Which this
patch doesn't use because the tests require wal_level=logical and
max_replication_slots >= 2. Andrew said on IRC that maybe it's a good
idea to add a make-contrib-check stage to the buildfarm.
A patch fixing a couple of absolutely trivial things is attached.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services