Re: pgsql: Further code review for pg_lsn data type.

On 2014-02-20 10:25:20 -0500, Tom Lane wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
> > On 2014-02-20 09:59:51 -0500, Tom Lane wrote:
> >> I think you're making a problem out of nothing.  We have considerably
> >> more-real portability issues to worry about, like memory ordering.
>
> > I don't think it's a huge problem, but it's pretty easy to avoid, so why
> > not avoid it?
>
> It's *not* that easy to avoid.  If we turn Datum into a struct we face a
> very significant risk of performance problems

All that's needed in this case is to copy DatumGetInt64/Int64GetDatum's definition and
avoid the intermediatry casts to int64.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services