Re: pgsql: Check dup2() results in syslogger

Поиск
Список
Период
Сортировка
От Stephen Frost
Тема Re: pgsql: Check dup2() results in syslogger
Дата
Msg-id 20140128134539.GJ31026@tamriel.snowman.net
обсуждение исходный текст
Ответ на Re: pgsql: Check dup2() results in syslogger  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> >> In short, this patch was ill considered.  Please revert.  If we need
> >> to silence a Coverity complaint, perhaps a cast-to-void will do?
>
> > Sure, I'll adjust it accordingly.
>
> Feel free to improve the comment if you think it could be clearer.

I hemmed and hawed over it and tried to improve it but I'm not convinced
that I did.  Still, I went ahead and at least got the revert committed.
If anyone feels the comment change hurts more than helps, let me know.

    Thanks,

        Stephen

Вложения

В списке pgsql-committers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: pgsql: Revert dup2() checking in syslogger.c
Следующее
От: Bruce Momjian
Дата:
Сообщение: pgsql: Remove orphaned prototype