Re: Hot standby 9.2.6 -> 9.2.6 PANIC: WAL contains references to invalid pages

On 2014-01-13 20:15:59 -0500, Tom Lane wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
> > On 2014-01-13 23:29:59 +0200, Heikki Linnakangas wrote:
> >> I don't think that saves us. standbyMode can be STANDBY_SNAPSHOT_READY,
> >> before we reach consistency. Adding a check for reachedConsistency, though,
> >> ought to fix it.
>
> > Maybe we should just put LocalHotStandbyActive into xlog_internal.h?
> > That'd be enough for the startup process. Or alternatively add a check
> > for EnableHotStandby into HotStandbyActive() so we don't take the
> > spinlock if it's not enabled?
>
> After a little bit of research, I propose that we add a function like
> this in xlog.c:

> Any objections?  Bikeshedding on the name?

Fine with me.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services