Robert Haas <robertmhaas@gmail.com> writes:
> Did you look at the
> patch to move the numeric stuff out of the .h file that I attached a
> few emails back? If that looks OK, I can commit it and then redo the
> rest of this along the lines we've discussed.
A couple of thoughts:
* It'd be good to get NUMERIC_HDRSZ out of there too, especially since
it'll have only the shakiest connection to reality after this patch goes in.
It looks like doing that would only require modifying type_maximum_size().
I'd suggest inventing another small function along the lines ofint32 numeric_maximum_size(int32 typemod)
so that the NUMERIC-specific knowledge can be pulled out of format_type.c.
* I'd suggest leaving a comment along the lines of/* The actual contents of Numeric are private to numeric.c */
with the now-opaque typedef for Numeric.
Otherwise +1.
regards, tom lane