Re: trailing comment ghost-timing

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: trailing comment ghost-timing
Дата
Msg-id 20131227091431.GA25163@alap2.anarazel.de
обсуждение исходный текст
Ответ на Re: trailing comment ghost-timing  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: trailing comment ghost-timing
Список pgsql-hackers
On 2013-12-24 12:27:59 -0500, Tom Lane wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
> >> This is inconsistent, IMO.  I think if we were to fix things so that
> >> leading block comments were dropped the same way -- comments are, that
> >> would also take care of the behavior complained of in this thread.
> >> There's been some previous discussion of this point, I think.
> 
> > FWIW, I find dropping comments a rather annoying behaviour. I'd rather
> > include dash comments in the statements sent to the server than start
> > dropping block comments.
> 
> What I was proposing was that we do include comments in what we send,
> as long as those comments are embedded in the statement text, not
> on lines before it.

The common way I've seen what I've described above done as is something
like:
/* File:path/to/some/file.whatever Function:foo::something()* Comment: Expensive, but that's ok!*/
SELECT here_comes FROM my WHERE some_sql;

If I unerstood what you propose correctly, we'd now drop that comment,
where we sent it before?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: preserving forensic information when we freeze
Следующее
От: Michael Meskes
Дата:
Сообщение: Re: [bug fix] connection service file doesn't take effect with ECPG apps