Dimitri,
* Dimitri Fontaine (dimitri@2ndQuadrant.fr) wrote:
> As the path didn't make it already, yes it needs another (final) round
> of review. The main difficulty in reviewing is understanding the design
> and the relation in between our current model of extensions and what
> this patch offers.
I'm afraid this really needs more work, at least of the more mundane
kind. I started working through this patch, but when I hit on
"get_template_oid", I was reminded of the discussion we had back in
January around using just 'template' everywhere.
http://www.postgresql.org/message-id/20130118182156.GF16126@tamriel.snowman.net
We already have other 'template' objects in the system and I'm not
excited about the confusion. This also applies to 'CreateTemplate',
'CreateTemplateTupleDesc', right down to 'template.h' and 'template.c'.
Attached is a patch against v16 which fixes up a few documentation
issues (I'm pretty sure extension templates and aggregates are
unrelated..), and points out that there is zero documentation on these
new catalog tables (look for 'XXX' in the patch) along with a few
other areas which could use improvement.
Thanks,
Stephen