Re: appendPQExpBufferVA vs appendStringInfoVA

Поиск
Список
Период
Сортировка
От Marko Kreen
Тема Re: appendPQExpBufferVA vs appendStringInfoVA
Дата
Msg-id 20131117120132.GA10778@gmail.com
обсуждение исходный текст
Ответ на Re: appendPQExpBufferVA vs appendStringInfoVA  (David Rowley <dgrowleyml@gmail.com>)
Ответы Re: appendPQExpBufferVA vs appendStringInfoVA  (David Rowley <dgrowleyml@gmail.com>)
Список pgsql-hackers
On Thu, Nov 14, 2013 at 09:33:59PM +1300, David Rowley wrote:
> On Sun, Nov 3, 2013 at 3:18 AM, David Rowley <dgrowleyml@gmail.com> wrote:
> > I'm low on ideas on how to improve things much around here for now, but
> > for what it's worth, I did create a patch which changes unnecessary calls
> > to appendPQExpBuffer() into calls to appendPQExpBufferStr() similar to the
> > recent one for appendStringInfo and appendStringInfoString.
> >
> Attached is a re-based version of this.

It does not apply anymore, could you resend it?

I am bit suspicious of performance impact of this patch, but think
that it's still worthwhile as it decreases code style where single
string argument is given to printf-style function without "%s".

-- 
marko




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ian Lawrence Barwick
Дата:
Сообщение: Review: pset autocomplete add missing options
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: pre-commit triggers