Re: output/security_label.source referring to abs_builddir instead of libdir

Поиск
Список
Период
Сортировка
От Noah Misch
Тема Re: output/security_label.source referring to abs_builddir instead of libdir
Дата
Msg-id 20130923200901.GB18041@tornado.leadboat.com
обсуждение исходный текст
Ответ на output/security_label.source referring to abs_builddir instead of libdir  (Hamid Quddus Akhtar <hamid.quddus@enterprisedb.com>)
Список pgsql-hackers
On Tue, Sep 17, 2013 at 07:04:14PM +0500, Hamid Quddus Akhtar wrote:
> In make check, there are 4 shared libraries that are loaded for test cases
> from the src/test/regress folder. Whereas, output of other libraries
> contain @libdir@ tag, the output file for security_label (dumm_seclabel)
> contains a tag for @abs_builddir@ in the output/security_label.source file.
> 
> I believe this an issue, and rather than referring @abs_builddir@, it
> should instead contain the tag @libdir@. Also note that while I could
> provide a path for dynamic libraries via "dlpath" option of pg_regress,
> this is not honored by security_label test case.
> 
> PFA patch for this fix.

More simply, if input/security_label.source says @libdir@,
output/security_label.source ought to match that.  Committed.

-- 
Noah Misch
EnterpriseDB                                 http://www.enterprisedb.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Noah Misch
Дата:
Сообщение: Re: pgbench progress report improvements - split 1
Следующее
От: Robert Haas
Дата:
Сообщение: Re: UTF8 national character data type support WIP patch and list of open issues.