Re: pg_system_identifier()

Hi,

On 2013-08-26 10:10:54 -0700, Josh Berkus wrote:
> I think we've gotten a bit off the track of the proposed patch, which is
> designed to report the system_identifier string currently in
> pg_controldata, nothing more.

Agreed.

> I'm going to reverse my vote, and vote against this patch.  The reason
> why is that I think we should instead have a function:
> 
> pg_controldata(parameter text)
> 
> ... which would report *all* strings in pg_controldata.  Hence, you'd do
> instead:
> 
> pg_controldata('system identifier')
> 
> This will hopefully spare us from 15 patches incrementally adding all of
> the individual items in controldata.

If anything but the proposed feature, it should be an SRF - passing in
text parameters isn't very discoverable. And I can't imagine where an
SRF would have too high overhead.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services