signed vs. unsigned in plpy_procedure.c

Поиск
Список
Период
Сортировка
От Andres Freund
Тема signed vs. unsigned in plpy_procedure.c
Дата
Msg-id 20130702103946.GB25626@alap2.anarazel.de
обсуждение исходный текст
Ответы Re: signed vs. unsigned in plpy_procedure.c  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Список pgsql-hackers
Hi,

src/postgresql/src/pl/plpython/plpy_procedure.c: In function ‘PLy_procedure_munge_source’:
src/postgresql/src/pl/plpython/plpy_procedure.c:507:2: warning: comparison of unsigned expression >= 0 is always true
[-Wtype-limits]
  Assert(plen >= 0 && plen < mlen);

Which has a point, we assign sprintf()s result to a size_t and then
check for a negative value. Which doesn't work.

Obviously the impact is miniscule, but removing legitimate warnings is a
good thing. Trivial patch attached.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "MauMau"
Дата:
Сообщение: Re: pgsql_tmp and external sort
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist