Re: units in postgresql.conf comments

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: units in postgresql.conf comments
Дата
Msg-id 20130530034334.GB4715@momjian.us
обсуждение исходный текст
Ответ на units in postgresql.conf comments  (Peter Eisentraut <peter_e@gmx.net>)
Ответы Re: units in postgresql.conf comments
Список pgsql-hackers
On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote:
> I think these sort of entries don't make much sense:
> 
> #wal_sender_timeout = 60s      # in milliseconds; 0 disables
> 
> I think we should remove units from the comments when it's clear from
> the name or the default value that time units are accepted.

We are documenting what happens when there are no units.  Are people are
going to change '60s' to '50' and assume that is '50s'?  Hopefully not. 
I do like the clutter avoidance of removing the units from the comments.


--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: Running pgindent
Следующее
От: Jeff Davis
Дата:
Сообщение: Eliminating PD_ALL_VISIBLE, take 2