Re: Running pgindent

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Running pgindent
Дата
Msg-id 20130529215632.GB2548@eldon.alvh.no-ip.org
обсуждение исходный текст
Ответ на Re: Running pgindent  (Bruce Momjian <bruce@momjian.us>)
Ответы Re: Running pgindent
Список pgsql-hackers
Bruce Momjian escribió:

> Done.  This was the first run of the Perl-based pgindent script.  There
> was a lot of code churn in this run as the paragraphs are slightly
> wider.  Also, I saw some outdenting of long lines, rather than allowing
> them to go past 80 characters, but it seemed minimal.  If others see
> problems, we can adjust the script and run it again.

It seems a bit troubling to me that the underlying indent binary seems
to have behaved slightly different.  I think this will cause problems
down the road when we try to backpatch stuff that has been indented
differently on the older branches.

I wonder if it would be best to inflict pgindent with the new script upon
the old active branches as well, to avoid this problem.  (It might cause
other problems, of course.)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: Running pgindent
Следующее
От: David Powers
Дата:
Сообщение: Re: streaming replication, "frozen snapshot backup on it" and missing relfile (postgres 9.2.3 on xfs + LVM)