On Fri, May 3, 2013 at 01:02:08PM +0200, Cédric Villemain wrote:
> > > > > This changes the existing API which will confuse people that know it
> > > > > and invalidate everything written in software and on wikis as to how
> > > > > to do it. That means all the "in case of fire break glass"
> > > > > instructions are all wrong and need to be rewritten and retested.
> > > >
> > > > Yes, *that* is the main reason *not* to make the change. It has a
> > > > pretty bad cost in backwards compatibility loss. There is a gain, but
> > > > I don't think it outweighs the cost.
> > >
> > > So, is there a way to add this feature without breaking the API?
> >
> > Yes, by adding a new parameter exclusively used to control this feature,
> > something like recovery_target_immediate = 'on/off'.
>
> We just need to add a named restore point when ending the backup (in
> pg_stop_backup() ?).
> No API change required. Just document that some predefined target names are set
> during backup.
So we auto-add a restore point based on the backup label. Does that
work for everyone?
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ It's impossible for everything to be true. +