Re: [PATCH] pg_regress and non-default unix socket path

Re: To PostgreSQL Hackers 2013-04-09 <20130409120807.GD26705@msgid.df7cb.de>

If the patch looks too intrusive at this stage of the release, it
would be enough if the last chunk got included, which should really be
painless:

> diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
> new file mode 100644
> index b632326..d4d4279
> *** a/src/test/regress/pg_regress.c
> --- b/src/test/regress/pg_regress.c

[...]

> *************** regression_main(int argc, char *argv[],
> *** 2249,2255 ****
>            */
>           header(_("starting postmaster"));
>           snprintf(buf, sizeof(buf),
> !                  SYSTEMQUOTE "\"%s/postgres\" -D \"%s/data\" -F%s -c \"listen_addresses=%s\" >
\"%s/log/postmaster.log\"2>&1" SYSTEMQUOTE,
 
>                    bindir, temp_install,
>                    debug ? " -d 5" : "",
>                    hostname ? hostname : "",
> --- 2254,2262 ----
>            */
>           header(_("starting postmaster"));
>           snprintf(buf, sizeof(buf),
> !                  hostname && *hostname == '/'
> !                      ? SYSTEMQUOTE "\"%s/postgres\" -D \"%s/data\" -F%s -k \"%s\" > \"%s/log/postmaster.log\" 2>&1"
SYSTEMQUOTE
> !                      : SYSTEMQUOTE "\"%s/postgres\" -D \"%s/data\" -F%s -c \"listen_addresses=%s\" >
\"%s/log/postmaster.log\"2>&1" SYSTEMQUOTE,
 
>                    bindir, temp_install,
>                    debug ? " -d 5" : "",
>                    hostname ? hostname : "",

Christoph
-- 
cb@df7cb.de | http://www.df7cb.de/