Re: CF3+4 (was Re: Parallel query execution)

Поиск
Список
Период
Сортировка
От Noah Misch
Тема Re: CF3+4 (was Re: Parallel query execution)
Дата
Msg-id 20130116155614.GA25278@tornado.leadboat.com
обсуждение исходный текст
Ответ на Re: CF3+4 (was Re: Parallel query execution)  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-hackers
On Wed, Jan 16, 2013 at 01:08:27PM +0100, Magnus Hagander wrote:
> On Wed, Jan 16, 2013 at 9:21 AM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
> > At 2013-01-16 02:07:29 -0500, tgl@sss.pgh.pa.us wrote:
> >>
> >> In case you hadn't noticed, we've totally lost control of
> >> the CF process.
> >
> > What can we do to get it back on track?
> 
> Not sure. One start might be to actually start having commitfest
> managers. I haven't actually checked numbers, but my feeling is that
> last round most commitfests (maybe not all) had a commitfest manager
> that worked (usually hard) at keeping things moving, whereas this
> round most (or all?) commitfests have been unmanaged. I'm not sure if
> that's the reason for it, but it's a feeling I have..

Agreed.

> > I want to help, but I don't know what's wrong. What are the committers
> > working on, and what is the status of the "Ready for commiter" patches?
> > Is the problem that the patches marked Ready aren't, in fact, ready? Or
> > is it lack of feedback from authors? Or something else?
> 
> I'm not one of the committers that pick up the most patches, but from
> reading messages on the lists I think fairly often patches that are
> marked as ready, aren't. Sometimes they require a small change, which
> is fine, but more often than not once it hits a committer it ends up
> with a lot of feedback requiring rather extensive changes.

That's an intrinsic hazard of non-committer reviews.  All the people who are
truly skilled at distinguishing ready patches from not-ready patches are
already committers, but a non-committer review catching even one important
problem adds value.  I'd rather have more people getting involved in the
process with high-effort reviews, however imperfect.

> As in it
> technical works, but it's better to do it in a different way. I'm not
> sure how to catch those better.

That's even harder, because it's subjective.  Committers often disagree on
such matters.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Curious buildfarm failures (fwd)
Следующее
От: Noah Misch
Дата:
Сообщение: Re: Parallel query execution