Re: [PATCH] Compile without warning with gcc's -Wtype-limits, -Wempty-body

On 2013-01-14 20:39:05 -0500, Peter Eisentraut wrote:
> On Tue, 2013-01-15 at 00:29 +0100, Andres Freund wrote:
> > Independently from this patch, should we add -Wtype-limits to the
> > default parameters?
> 
> I think we have had a discussion along this line before.  I am against
> fixing warnings from this option, because those changes would hide
> errors if a variable's type changed from signed to unsigned or vice
> versa, which could happen because of refactoring or it might be
> dependent on system headers.

Well, I already found a bug (although with very limited consequences) in
the walsender code and one with graver consequences in code I just
submitted. So I don't really see that being on-par with some potential
future refactoring...

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services