Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs
Дата
Msg-id 20130109124735.GE5759@awork2.anarazel.de
обсуждение исходный текст
Ответ на Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs  (Magnus Hagander <magnus@hagander.net>)
Ответы Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-hackers
On 2013-01-09 13:34:12 +0100, Magnus Hagander wrote:
> Am I the only one who finds this way of posting patches really annoying?

Well, I unsurprisingly don't ;)

> Here is a patch with no description other than a list of changed
> files. And discussion happens in a completely different email.

They contain the commit message - which in most of the cases is more
informative than the one just posted, which was definitely rather
short. It should like in
e.g.http://archives.postgresql.org/message-id/1352942234-3953-11-git-send-email-andres%402ndquadrant.com

> What's wrong with just posting the patch as a regular attachment(s) to
> a regular thread, like other people do?

Two issues:
- If you have a bigger series of patches (like the whole logical decoding thing) posting all patches in a single mail
makesthe following thread even harder to follow than its currently the case. Note how even in this, far smaller, case
thediscussion actually happened in the appropriate subthreads. I find it way much easier to reread through an old
threadthat way to reassure myself what was discussed.
 
- mhonarc does really strange things if you attach two git created patches (splits them into multiple mails)

> It may be just me. But it may be others as well, so I figured I should
> raise the issue :)

I am happy to comply with whatever others prefer.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Simon Riggs
Дата:
Сообщение: Commitfest Topics
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs