Re: [PATCH] binary heap implementation

Поиск
Список
Период
Сортировка
От Abhijit Menon-Sen
Тема Re: [PATCH] binary heap implementation
Дата
Msg-id 20121122023951.GA26315@toroid.org
обсуждение исходный текст
Ответ на Re: [PATCH] binary heap implementation  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
At 2012-11-21 15:09:12 -0500, robertmhaas@gmail.com wrote:
>
> > The following comments still talk about "key and value", thus need
> > an update:
> 
> Oops.

In the same vein, "Returns NULL if the heap is empty" no longer applies
to binaryheap_first and binaryheap_remove_first. Plus there is an extra
asterisk in the middle of the comment about binaryheap_replace_first.

But it looks good otherwise.

I agree with Tom that we should support resizing the heap, but let's not
bother with that now. I'll write the few extra lines of code the first
time something actually needs to add more elements to a heap.

-- Abhijit



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jeff Davis
Дата:
Сообщение: Removing PD_ALL_VISIBLE
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: StrategyGetBuffer questions