Re: [PATCH] binary heap implementation

Robert Haas escribió:
> On Wed, Nov 14, 2012 at 8:11 AM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
> > Comments? Suggestions?
>
> It could use a run through pgindent.  And the header comments are
> separated by a blank line from the functions to which they are
> attached, which is not project style.

Also there are some comments in the .h file which we typically don't
carry.

> Other than the coding style issues, I think this looks fine.  If you
> can fix that up, I believe I could go ahead and commit this, unless
> anyone else objects.

Does this include the changes in nodeMergeappend.c?

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services