Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

On Wed, Nov 14, 2012 at 06:15:30PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Wed, Nov 14, 2012 at 05:39:29PM -0500, Tom Lane wrote:
> >> You would have been better off keeping the array and sorting it so you
> >> could use binary search, instead of passing the problem off to the
> >> filesystem.
>
> > Well, testing showed using open() was a big win.
>
> ... on the filesystem you tested on.  I'm concerned that it might not
> look so good on other platforms.

True. I am on ext3.  So I need to generate a proof-of-concept patch and
have others test it?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +