A while ago I noticed that in some places we strdup/pg_strdup() optarg
strings from getopt(), and in some places we don't.
If we needed the strdup(), the missing cases should generate errors. If
we don't need them, the strdup() is unnecessary, and research confirms
they are unnecessary. Should we remove the extra strdup/pg_strdup()
calls, for consistency.
I think we might have had old platforms that required it, but none are
still supported today.
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ It's impossible for everything to be true. +