On Sat, Aug 25, 2012 at 12:26:30PM -0400, Robert Haas wrote:
> > So a patch of 1K lines would by itself represent about 2% of the typical
> > inter-branch delta. Maybe that's below our threshold of pain, or maybe
> > it isn't. I'd be happier about it if there were a more compelling
> > argument for it, but to me it looks like extremely trivial neatnik-ism.
>
> I wouldn't mind a bit if we devoted 2% of our inter-branch deltas to
> this sort of thing, but I've got to admit that 2% for one patch seems
> a little on the high side to me. It might not be a bad idea to
> establish one formulation or the other as the one to be used in all
> new code, though, to avoid making the problem worse.
Patch withdrawn. If we ever do a major code churn, it might be good to
revisit this cleanup.
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ It's impossible for everything to be true. +