Re: Re: patch review : Add ability to constrain backend temporary file space

Поиск
Список
Период
Сортировка
От Tatsuo Ishii
Тема Re: Re: patch review : Add ability to constrain backend temporary file space
Дата
Msg-id 20110715.115709.411418020386079073.t-ishii@sraoss.co.jp
обсуждение исходный текст
Ответ на Re: Re: patch review : Add ability to constrain backend temporary file space  (Mark Kirkwood <mark.kirkwood@catalyst.net.nz>)
Ответы Re: Re: patch review : Add ability to constrain backend temporary file space
Список pgsql-hackers
>> I have looked into the v6 patches. One thing I would like to suggest
>> is, enhancing the error message when temp_file_limit will be exceeded.
>>
>> ERROR:  aborting due to exceeding temp file limit
>>
>> Is it possible to add the current temp file limit to the message? For
>> example,
>>
>> ERROR:  aborting due to exceeding temp file limit 10000kB
>>
>> I know the current setting of temp_file_limit can be viewd in other
>> ways, but I think this will make admin's or application developer's
>> life a little bit easier.
> 
> Hi Tatsuo,
> 
> Yeah, good suggestion - I agree that it would be useful to supply
> extra detail, I'll amend and resubmit a new patch (along with whatever
> review modifications we come up with in the meantime)!
> 
> Cheers
> 
> Mark

Maybe we could add more info regarding current usage and requested
amount in addition to the temp file limit value. I mean something
like:

ERROR:  aborting due to exceeding temp file limit. Current usage 9000kB, requested size 1024kB, thus it will exceed
tempfile limit 10000kB.
 

What do you think?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Shigeru Hanada
Дата:
Сообщение: Re: per-column generic option
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: Is there a committer in the house?