Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Simon Riggs wrote:
> >> I'm particularly concerned that people make such changes too quickly.
> >> There are many things in this area of code that need changing, but also
> >> many more that do not. If we are to move forwards we need to avoid going
> >> one step forwards, one step back.
>
> > There were enough people who wanted a change that we went ahead and did
> > it --- if there was lack of agreement, we would have delayed longer.
>
> The real reason why we changed this is that nobody (except Simon) sees
> a situation where unconditional logging of successful replication
> connections is especially helpful. If you were trying to diagnose a
> problem you would more likely need to know about *failed* connections,
> but the code that was in there didn't provide that. At least not unless
> you turned on log_connections ...
Yep.
Simon, I understand you being disappointed you could not champion your
cause during the discussion, but you can still try to sway people that
the original code was appropriate.
Based on the feedback from the group, it seemed unlikely you would be
able to sway a significant number of people so we just went ahead and
made the change.
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ It's impossible for everything to be true. +