Re: Add support for logging the current role

Greetings,

* Robert Haas (robertmhaas@gmail.com) wrote:
> 1. Why %o?  That's not obviously mnemonic.  Perhaps %U?
>
> 2. It won't be clear to people reading this what the difference is
> between %u and this.  You probably need to reword the documentation
> for the existing option as well as documenting the new one.
>
> 3. Please attach the patch rather than including it inline, if possible.

Updated patch attached-

commit 7319e8ddc91d62addea25b85f7dbe2f95132cdc1
Author: Stephen Frost <sfrost@snowman.net>
Date:   Wed Jan 12 10:23:13 2011 -0500

    Use %U for role in log_line_prefix; improve docs

    Change the variable for logging the current role in log_line_prefix
    from %o to %U, to better reflect the 'user'-type mnemonic.
    Improve the documentation for the %U and %u log_line_prefix options
    to better differentiate them from each other.

commit 3cb707aa9f228e629e7127625a76a223751a778b
Author: Stephen Frost <sfrost@snowman.net>
Date:   Wed Jan 12 09:17:31 2011 -0500

    Add support for logging the current role

    This adds a '%o' option to the log_line_prefix GUC which will log the
    current role.  The '%u' option only logs the Session user, which can
    be misleading, but it's valuable to have both options.

    Thanks!

        Stephen