Re: Fw: patch for pg_ctl.c to add windows service start-type
| От | Quan Zongliang |
|---|---|
| Тема | Re: Fw: patch for pg_ctl.c to add windows service start-type |
| Дата | |
| Msg-id | 20100822220332.6688a11c.quanzongliang@gmail.com обсуждение |
| Ответ на | Re: Fw: patch for pg_ctl.c to add windows service start-type (Magnus Hagander <magnus@hagander.net>) |
| Ответы |
Re: Fw: patch for pg_ctl.c to add windows service
start-type
Re: Fw: patch for pg_ctl.c to add windows service start-type |
| Список | pgsql-hackers |
Sure, I agree. New patch attached. How about this? On Fri, 20 Aug 2010 11:21:18 +0200 Magnus Hagander <magnus@hagander.net> wrote: > On Fri, Aug 20, 2010 at 01:01, Quan Zongliang <quanzongliang@gmail.com> wrote: > > Because Windows's CreateService has serial start-type: > > SERVICE_AUTO_START > > SERVICE_BOOT_START > > SERVICE_DEMAND_START > > SERVICE_DISABLED > > SERVICE_SYSTEM_START > > > > Although all of them are not useful for pg service. > > I think it is better to use enum. > > I don't see us ever using anything other than auto or demand. The > others aren't for "regular services", except for "disabled". And > adding a disabled service makes no sense :-) So I'm with Alvaro, I > think it's a good idea to simplify that. > > > -- > Magnus Hagander > Me: http://www.hagander.net/ > Work: http://www.redpill-linpro.com/ -- Quan Zongliang <quanzongliang@gmail.com>
Вложения
В списке pgsql-hackers по дате отправления: